-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Do not deploy jobs pod when using local eventbus #175
fix: Do not deploy jobs pod when using local eventbus #175
Conversation
{{- if eq (include "bindplane.deployment_type" .) "Deployment" }} | ||
{{- if ne .Values.eventbus.type "" }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If eventbus is not set, skip the jobs pod deployment.
{{- if eq (include "bindplane.deployment_type" .) "StatefulSet" }} | ||
{{- if eq .Values.eventbus.type "" }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If event bus is not set, set mode to all.
"type": { | ||
"type": "string", | ||
"enum": ["", "nats", "pubsub", "kafka"], | ||
"description": "The type of event bus used. Must be one of '', 'nats', 'pubsub', or 'kafka'." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will ensure users only configure eventbus.type
with the following values
- ""
- "nats"
- "postgres"
- "kafka"
Kafka is deprecated, and omitted from docs but should still be supported by the chart.
Description of Changes
When
eventbus.type: ""
(local), we should not deploy the jobs pod. We should also deploy the BindPlane pod with modeall
.It was assumed if "deployment type" was Deployment, that an event bus would be used for BindPlane HA. This is not the case. It is possible users would implement Postgres while sticking with local event bus (limited to one pod).
Deploying the jobs pod, and using mode "node" without an event bus will cause rollouts to fail.
Testing
Create
values.yaml
with the following.Start minikube
Deploy your license key
kubectl create secret generic bindplane \ --from-literal=license=$BINDPLANE_LICENSE
Deploy Postgres
Deploy the chart
You should see the following in the default namespace:
The
BINDPLANE_MODE
should be set toall
.You can upgrade to a NATS environment if using an Enterprise license. Modify the values file.
Redeploy:
This time, you should see the NATS pods, a jobs pod, and the deployment will have
mode: node
.Please check that the PR fulfills these requirements